From 76fb71f4b16e540b052d04d31085613f1c3acbc4 Mon Sep 17 00:00:00 2001
From: Diederik de Haas <didi.debian@cknow.org>
Date: Fri, 11 Nov 2022 19:05:57 +0100
Subject: [PATCH] ci: Add 'check yamls' job in (new) 'check input' stage

Add a new stage 'check input' to our CI configuration to check whether
our input files contain errors.
The first check is for the YAML files whether they contain errors or
warnings according to 'yamllint'.

Add 'yamllint' config file to not consider too long lines as errors.
And fix the errors/warnings in 'salsa-ci.yml' itself.

Apparently job names can contain space, so rename 'build-yamls' to
'build yamls'.
---
 debian/salsa-ci.yml | 15 +++++++++++++--
 debian/yamllint.yml |  6 ++++++
 2 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 debian/yamllint.yml

diff --git a/debian/salsa-ci.yml b/debian/salsa-ci.yml
index 13138a1..f43a844 100644
--- a/debian/salsa-ci.yml
+++ b/debian/salsa-ci.yml
@@ -1,4 +1,7 @@
+---
 stages:
+  # Garbage in is garbage out, so verify our input
+  - check input
   - build
 
 variables:
@@ -7,7 +10,16 @@ variables:
   SALSA_CI_IMAGES: registry.salsa.debian.org/salsa-ci-team/pipeline
   BASE_CI_IMAGES: ${SALSA_CI_IMAGES}/base
 
-build-yamls:
+check yamls:
+  stage: check input
+  image: $BASE_CI_IMAGES:unstable
+  dependencies: []
+  script:
+    - apt-get update && apt-get upgrade -y
+    - apt-get install -y yamllint
+    - yamllint -c debian/yamllint.yml .
+
+build yamls:
   stage: build
   image: $BASE_CI_IMAGES:unstable
   dependencies: []
@@ -20,4 +32,3 @@ build-yamls:
   artifacts:
     paths:
       - build/
-
diff --git a/debian/yamllint.yml b/debian/yamllint.yml
new file mode 100644
index 0000000..53974a0
--- /dev/null
+++ b/debian/yamllint.yml
@@ -0,0 +1,6 @@
+---
+
+extends: default
+
+rules:
+  line-length: disable